Implement limit directive for msgp array/map size bounds checking #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `//msgp:limit` directive to prevent DoS attacks by limiting array/slice and map sizes during msgp serialization/deserialization operations. Features: - Unified directive syntax: //msgp:limit arrays:n maps:n marshal:true/false - Applies only to dynamic slices/maps, excludes fixed arrays (compile-time sized) - Optional marshal-time enforcement with marshal:true parameter - Default limits of math.MaxUint32 when not specified - Returns msgp.ErrLimitExceeded when limits exceeded - Per-file unique constant generation using CRC32 hash to avoid collisions Usage examples: `//msgp:limit arrays:100 maps:50` (unmarshal limits only) `//msgp:limit arrays:100 maps:50 marshal:true` (both marshal and unmarshal limits)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
//msgp:limitdirective to prevent DoS attacks by limiting array/slice and map sizes during msgp serialization/deserialization operations.Features:
Usage examples:
//msgp:limit arrays:100 maps:50(unmarshal limits only)//msgp:limit arrays:100 maps:50 marshal:true(both marshal and unmarshal limits)Fixes #411